Skip to content

Commit 1db5322

Browse files
ausyskingregkh
authored andcommitted
mei: demote client disconnect warning on suspend to debug
Change level for the "not connected" client message in the write callback from error to debug. The MEI driver currently disconnects all clients upon system suspend. This behavior is by design and user-space applications with open connections before the suspend are expected to handle errors upon resume, by reopening their handles, reconnecting, and retrying their operations. However, the current driver implementation logs an error message every time a write operation is attempted on a disconnected client. Since this is a normal and expected flow after system resume logging this as an error can be misleading. Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Link: https://lore.kernel.org/r/20240530091415.725247-1-tomas.winkler@intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent c3f38fa commit 1db5322

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/misc/mei/main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ static ssize_t mei_write(struct file *file, const char __user *ubuf,
329329
}
330330

331331
if (!mei_cl_is_connected(cl)) {
332-
cl_err(dev, cl, "is not connected");
332+
cl_dbg(dev, cl, "is not connected");
333333
rets = -ENODEV;
334334
goto out;
335335
}

0 commit comments

Comments
 (0)