bcachefs: fix backpointer_to_text() when dev does not exist

Kent Overstreet · Kent Overstreet · commit 1f626223a0c8 · 2024-02-24T20:41:37.000-05:00
Fixes:
Signed-off-by: Kent Overstreet &lt;kent.overstreet@linux.dev&gt;
diff --git a/fs/bcachefs/backpointers.c b/fs/bcachefs/backpointers.c
@@ -68,9 +68,11 @@ void bch2_backpointer_to_text(struct printbuf *out, const struct bch_backpointer
 
 void bch2_backpointer_k_to_text(struct printbuf *out, struct bch_fs *c, struct bkey_s_c k)
 {
-	prt_str(out, "bucket=");
-	bch2_bpos_to_text(out, bp_pos_to_bucket(c, k.k->p));
-	prt_str(out, " ");
+	if (bch2_dev_exists2(c, k.k->p.inode)) {
+		prt_str(out, "bucket=");
+		bch2_bpos_to_text(out, bp_pos_to_bucket(c, k.k->p));
+		prt_str(out, " ");
+	}
 
 	bch2_backpointer_to_text(out, bkey_s_c_to_backpointer(k).v);
 }

Original file line number	Diff line number	Diff line change
`@@ -68,9 +68,11 @@ void bch2_backpointer_to_text(struct printbuf *out, const struct bch_backpointer`
`68`	`68`
`69`	`69`	`void bch2_backpointer_k_to_text(struct printbuf out, struct bch_fs c, struct bkey_s_c k)`
`70`	`70`	`{`
`71`		`- prt_str(out, "bucket=");`
`72`		`- bch2_bpos_to_text(out, bp_pos_to_bucket(c, k.k->p));`
`73`		`- prt_str(out, " ");`
	`71`	`+ if (bch2_dev_exists2(c, k.k->p.inode)) {`
	`72`	`+ prt_str(out, "bucket=");`
	`73`	`+ bch2_bpos_to_text(out, bp_pos_to_bucket(c, k.k->p));`
	`74`	`+ prt_str(out, " ");`
	`75`	`+ }`
`74`	`76`
`75`	`77`	`bch2_backpointer_to_text(out, bkey_s_c_to_backpointer(k).v);`
`76`	`78`	`}`