Skip to content

Commit 1f9fc89

Browse files
committed
ALSA: seq: Fix KCSAN data-race warning at snd_seq_fifo_poll_wait()
snd_seq_fifo_poll_wait() evaluates f->cells without locking after poll_wait(), and KCSAN doesn't like it as it appears to be a data-race. Although this doesn't matter much in practice as the value is volatile, it's still better to address it for the mind piece. Wrap it with f->lock spinlock for avoiding the potential data race. Reported-by: syzbot+c3dbc239259940ededba@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?extid=c3dbc239259940ededba Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 7e18682 commit 1f9fc89

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

sound/core/seq/seq_fifo.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,7 @@ int snd_seq_fifo_poll_wait(struct snd_seq_fifo *f, struct file *file,
210210
poll_table *wait)
211211
{
212212
poll_wait(file, &f->input_sleep, wait);
213+
guard(spinlock_irq)(&f->lock);
213214
return (f->cells > 0);
214215
}
215216

0 commit comments

Comments
 (0)