Skip to content

Commit 1fbe3ab

Browse files
krzklinusw
authored andcommitted
pinctrl: qcom: sm8350-lpass-lpi: Merge with SC7280 to fix I2S2 and SWR TX pins
Qualcomm SC7280 and SM8350 SoCs have slightly different LPASS audio blocks (v9.4.5 and v9.2), however the LPASS LPI pin controllers are exactly the same. The driver for SM8350 has two issues, which can be fixed by simply moving over to SC7280 driver which has them correct: 1. "i2s2_data_groups" listed twice GPIO12, but should have both GPIO12 and GPIO13, 2. "swr_tx_data_groups" contained GPIO5 for "swr_tx_data2" function, but that function is also available on GPIO14, thus listing it twice is not necessary. OTOH, GPIO5 has also "swr_rx_data1", so selecting swr_rx_data function should not block the TX one. Fixes: be9f6d5 ("pinctrl: qcom: sm8350-lpass-lpi: add SM8350 LPASS TLMM") Cc: stable@vger.kernel.org Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Linus Walleij <linusw@kernel.org>
1 parent 28f2406 commit 1fbe3ab

5 files changed

Lines changed: 6 additions & 165 deletions

File tree

arch/arm64/configs/defconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -670,7 +670,6 @@ CONFIG_PINCTRL_LPASS_LPI=m
670670
CONFIG_PINCTRL_SC7280_LPASS_LPI=m
671671
CONFIG_PINCTRL_SM6115_LPASS_LPI=m
672672
CONFIG_PINCTRL_SM8250_LPASS_LPI=m
673-
CONFIG_PINCTRL_SM8350_LPASS_LPI=m
674673
CONFIG_PINCTRL_SM8450_LPASS_LPI=m
675674
CONFIG_PINCTRL_SC8280XP_LPASS_LPI=m
676675
CONFIG_PINCTRL_SM8550_LPASS_LPI=m

drivers/pinctrl/qcom/Kconfig

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,14 @@ config PINCTRL_LPASS_LPI
6161
(Low Power Island) found on the Qualcomm Technologies Inc SoCs.
6262

6363
config PINCTRL_SC7280_LPASS_LPI
64-
tristate "Qualcomm Technologies Inc SC7280 LPASS LPI pin controller driver"
64+
tristate "Qualcomm Technologies Inc SC7280 and SM8350 LPASS LPI pin controller driver"
6565
depends on ARM64 || COMPILE_TEST
6666
depends on PINCTRL_LPASS_LPI
6767
help
6868
This is the pinctrl, pinmux, pinconf and gpiolib driver for the
6969
Qualcomm Technologies Inc LPASS (Low Power Audio SubSystem) LPI
70-
(Low Power Island) found on the Qualcomm Technologies Inc SC7280 platform.
70+
(Low Power Island) found on the Qualcomm Technologies Inc SC7280
71+
and SM8350 platforms.
7172

7273
config PINCTRL_SDM660_LPASS_LPI
7374
tristate "Qualcomm Technologies Inc SDM660 LPASS LPI pin controller driver"
@@ -106,16 +107,6 @@ config PINCTRL_SM8250_LPASS_LPI
106107
Qualcomm Technologies Inc LPASS (Low Power Audio SubSystem) LPI
107108
(Low Power Island) found on the Qualcomm Technologies Inc SM8250 platform.
108109

109-
config PINCTRL_SM8350_LPASS_LPI
110-
tristate "Qualcomm Technologies Inc SM8350 LPASS LPI pin controller driver"
111-
depends on ARM64 || COMPILE_TEST
112-
depends on PINCTRL_LPASS_LPI
113-
help
114-
This is the pinctrl, pinmux, pinconf and gpiolib driver for the
115-
Qualcomm Technologies Inc LPASS (Low Power Audio SubSystem) LPI
116-
(Low Power Island) found on the Qualcomm Technologies Inc SM8350
117-
platform.
118-
119110
config PINCTRL_SM8450_LPASS_LPI
120111
tristate "Qualcomm Technologies Inc SM8450 LPASS LPI pin controller driver"
121112
depends on ARM64 || COMPILE_TEST

drivers/pinctrl/qcom/Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ obj-$(CONFIG_PINCTRL_SM8150) += pinctrl-sm8150.o
6464
obj-$(CONFIG_PINCTRL_SM8250) += pinctrl-sm8250.o
6565
obj-$(CONFIG_PINCTRL_SM8250_LPASS_LPI) += pinctrl-sm8250-lpass-lpi.o
6666
obj-$(CONFIG_PINCTRL_SM8350) += pinctrl-sm8350.o
67-
obj-$(CONFIG_PINCTRL_SM8350_LPASS_LPI) += pinctrl-sm8350-lpass-lpi.o
6867
obj-$(CONFIG_PINCTRL_SM8450) += pinctrl-sm8450.o
6968
obj-$(CONFIG_PINCTRL_SM8450_LPASS_LPI) += pinctrl-sm8450-lpass-lpi.o
7069
obj-$(CONFIG_PINCTRL_SM8550) += pinctrl-sm8550.o

drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,9 @@ static const struct of_device_id lpi_pinctrl_of_match[] = {
131131
{
132132
.compatible = "qcom,sc7280-lpass-lpi-pinctrl",
133133
.data = &sc7280_lpi_data,
134+
}, {
135+
.compatible = "qcom,sm8350-lpass-lpi-pinctrl",
136+
.data = &sc7280_lpi_data,
134137
},
135138
{ }
136139
};

drivers/pinctrl/qcom/pinctrl-sm8350-lpass-lpi.c

Lines changed: 0 additions & 151 deletions
This file was deleted.

0 commit comments

Comments
 (0)