Skip to content

Commit 1fcb760

Browse files
laura-naoAngeloGioacchino Del Regno
authored andcommitted
arm64: dts: mediatek: mt8192-asurada-spherion: Mark trackpads as fail-needs-probe
Different Spherion variants use different trackpads on the same I2C2 bus. Instead of enabling all of them by default, mark them as "fail-needs-probe" and let the implementation determine which one is actually present. Additionally, move the trackpad pinctrl entry back to the individual trackpad nodes. Signed-off-by: Laura Nao <laura.nao@collabora.com> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Link: https://lore.kernel.org/r/20250318102259.189289-3-laura.nao@collabora.com Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
1 parent 85c767d commit 1fcb760

2 files changed

Lines changed: 11 additions & 2 deletions

File tree

arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,15 @@
8585
trackpad@2c {
8686
compatible = "hid-over-i2c";
8787
reg = <0x2c>;
88+
pinctrl-names = "default";
89+
pinctrl-0 = <&trackpad_pins>;
8890
hid-descr-addr = <0x20>;
8991
interrupts-extended = <&pio 15 IRQ_TYPE_LEVEL_LOW>;
9092
wakeup-source;
93+
status = "fail-needs-probe";
9194
};
9295
};
96+
97+
&trackpad {
98+
status = "fail-needs-probe";
99+
};

arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -346,11 +346,13 @@
346346
clock-frequency = <400000>;
347347
clock-stretch-ns = <12600>;
348348
pinctrl-names = "default";
349-
pinctrl-0 = <&i2c2_pins>, <&trackpad_pins>;
349+
pinctrl-0 = <&i2c2_pins>;
350350

351-
trackpad@15 {
351+
trackpad: trackpad@15 {
352352
compatible = "elan,ekth3000";
353353
reg = <0x15>;
354+
pinctrl-names = "default";
355+
pinctrl-0 = <&trackpad_pins>;
354356
interrupts-extended = <&pio 15 IRQ_TYPE_LEVEL_LOW>;
355357
vcc-supply = <&pp3300_u>;
356358
wakeup-source;

0 commit comments

Comments
 (0)