Skip to content

Commit 2251db2

Browse files
krzkbroonie
authored andcommitted
ASoC: codecs: wcd937x: Fix missing de-assert of reset GPIO
The device never comes online from a reset/shutdown state, because the driver de-asserts reset GPIO when requesting it but then, at the end of probe() through wcd937x_reset(), leaves it asserted. Cc: stable@vger.kernel.org Fixes: 9be3ec1 ("ASoC: codecs: wcd937x: add wcd937x codec driver") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://patch.msgid.link/20240806114913.40022-1-krzysztof.kozlowski@linaro.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent c0196fa commit 2251db2

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

sound/soc/codecs/wcd937x.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -242,10 +242,9 @@ static const struct regmap_irq_chip wcd937x_regmap_irq_chip = {
242242

243243
static void wcd937x_reset(struct wcd937x_priv *wcd937x)
244244
{
245-
usleep_range(20, 30);
246-
247245
gpiod_set_value(wcd937x->reset_gpio, 1);
248-
246+
usleep_range(20, 30);
247+
gpiod_set_value(wcd937x->reset_gpio, 0);
249248
usleep_range(20, 30);
250249
}
251250

0 commit comments

Comments
 (0)