Skip to content

Commit 2295657

Browse files
willyhuang1Jiri Kosina
authored andcommitted
HID: nintendo: Reduce JC_SUBCMD_RATE_MAX_ATTEMPTS
The JC_SUBCMD_RATE_MAX_ATTEMPTS constant is currently set to 500. In a worst-case scenario where all attempts consistently fail, this could cause the loop to block for up to 60000 ms (500 * 60ms * 2, including the additional retry after a timeout). This change lowers the maximum potential blocking time to 3000 ms (25 * 60ms * 2), improving system responsiveness and efficiency. Signed-off-by: Willy Huang <willyhuang@google.com> Reviewed-by: Daniel J. Ogorchock <djogorchock@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.com>
1 parent 2953fb6 commit 2295657

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/hid/hid-nintendo.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -819,7 +819,7 @@ static void joycon_wait_for_input_report(struct joycon_ctlr *ctlr)
819819
#define JC_INPUT_REPORT_MAX_DELTA 17
820820
#define JC_SUBCMD_TX_OFFSET_MS 4
821821
#define JC_SUBCMD_VALID_DELTA_REQ 3
822-
#define JC_SUBCMD_RATE_MAX_ATTEMPTS 500
822+
#define JC_SUBCMD_RATE_MAX_ATTEMPTS 25
823823
#define JC_SUBCMD_RATE_LIMITER_USB_MS 20
824824
#define JC_SUBCMD_RATE_LIMITER_BT_MS 60
825825
#define JC_SUBCMD_RATE_LIMITER_MS(ctlr) ((ctlr)->hdev->bus == BUS_USB ? JC_SUBCMD_RATE_LIMITER_USB_MS : JC_SUBCMD_RATE_LIMITER_BT_MS)

0 commit comments

Comments
 (0)