Skip to content

Commit 22a36e6

Browse files
vprosyakalexdeucher
authored andcommitted
drm/amdgpu: disable peer-to-peer access for DCC-enabled GC12 VRAM surfaces
Certain multi-GPU configurations (especially GFX12) may hit data corruption when a DCC-compressed VRAM surface is shared across GPUs using peer-to-peer (P2P) DMA transfers. Such surfaces rely on device-local metadata and cannot be safely accessed through a remote GPU’s page tables. Attempting to import a DCC-enabled surface through P2P leads to incorrect rendering or GPU faults. This change disables P2P for DCC-enabled VRAM buffers that are contiguous and allocated on GFX12+ hardware. In these cases, the importer falls back to the standard system-memory path, avoiding invalid access to compressed surfaces. Future work could consider optional migration (VRAM→System→VRAM) if a performance regression is observed when `attach->peer2peer = false`. Tested on: - Dual RX 9700 XT (Navi4x) setup - GNOME and Wayland compositor scenarios - Confirmed no corruption after disabling P2P under these conditions v2: Remove check TTM_PL_VRAM & TTM_PL_FLAG_CONTIGUOUS. v3: simplify for upsteam and fix ip version check (Alex) Suggested-by: Christian König <christian.koenig@amd.com> Signed-off-by: Vitaly Prosyak <vitaly.prosyak@amd.com> Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> (cherry picked from commit 9dff2bb) Cc: stable@vger.kernel.org
1 parent e9a6fb0 commit 22a36e6

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,18 @@ static int amdgpu_dma_buf_attach(struct dma_buf *dmabuf,
8282
struct amdgpu_bo *bo = gem_to_amdgpu_bo(obj);
8383
struct amdgpu_device *adev = amdgpu_ttm_adev(bo->tbo.bdev);
8484

85+
/*
86+
* Disable peer-to-peer access for DCC-enabled VRAM surfaces on GFX12+.
87+
* Such buffers cannot be safely accessed over P2P due to device-local
88+
* compression metadata. Fallback to system-memory path instead.
89+
* Device supports GFX12 (GC 12.x or newer)
90+
* BO was created with the AMDGPU_GEM_CREATE_GFX12_DCC flag
91+
*
92+
*/
93+
if (amdgpu_ip_version(adev, GC_HWIP, 0) >= IP_VERSION(12, 0, 0) &&
94+
bo->flags & AMDGPU_GEM_CREATE_GFX12_DCC)
95+
attach->peer2peer = false;
96+
8597
if (!amdgpu_dmabuf_is_xgmi_accessible(attach_adev, bo) &&
8698
pci_p2pdma_distance(adev->pdev, attach->dev, false) < 0)
8799
attach->peer2peer = false;

0 commit comments

Comments
 (0)