driver core: platform: Switch to use kmemdup_array()

andy-shev · gregkh · commit 23c685967706 · 2024-07-04T12:02:38.000+02:00
Let the kememdup_array() take care about multiplication and possible overflows. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20240606164926.3031358-1-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
@@ -608,7 +608,7 @@ int platform_device_add_resources(struct platform_device *pdev,
 	struct resource *r = NULL;
 
 	if (res) {
-		r = kmemdup(res, sizeof(struct resource) * num, GFP_KERNEL);
+		r = kmemdup_array(res, num, sizeof(*r), GFP_KERNEL);
 		if (!r)
 			return -ENOMEM;
 	}

Original file line number	Diff line number	Diff line change
`@@ -608,7 +608,7 @@ int platform_device_add_resources(struct platform_device *pdev,`
`608`	`608`	`struct resource *r = NULL;`
`609`	`609`
`610`	`610`	`if (res) {`
`611`		`- r = kmemdup(res, sizeof(struct resource) * num, GFP_KERNEL);`
	`611`	`+ r = kmemdup_array(res, num, sizeof(*r), GFP_KERNEL);`
`612`	`612`	`if (!r)`
`613`	`613`	`return -ENOMEM;`
`614`	`614`	`}`