Skip to content

Commit 241c044

Browse files
ying zuxinbroonie
authored andcommitted
ASoC: codecs: Use devm_clk_get_enabled() helpers
The devm_clk_get_enabled() helpers: - call devm_clk_get() - call clk_prepare_enable() and register what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code and avoids the calls to clk_disable_unprepare(). Signed-off-by: ying zuxin <11154159@vivo.com> Link: https://patch.msgid.link/20240906084841.19248-1-yingzuxin@vivo.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 4849b2f commit 241c044

1 file changed

Lines changed: 1 addition & 13 deletions

File tree

sound/soc/codecs/peb2466.c

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1975,12 +1975,9 @@ static int peb2466_spi_probe(struct spi_device *spi)
19751975
if (IS_ERR(peb2466->reset_gpio))
19761976
return PTR_ERR(peb2466->reset_gpio);
19771977

1978-
peb2466->mclk = devm_clk_get(&peb2466->spi->dev, "mclk");
1978+
peb2466->mclk = devm_clk_get_enabled(&peb2466->spi->dev, "mclk");
19791979
if (IS_ERR(peb2466->mclk))
19801980
return PTR_ERR(peb2466->mclk);
1981-
ret = clk_prepare_enable(peb2466->mclk);
1982-
if (ret)
1983-
return ret;
19841981

19851982
if (peb2466->reset_gpio) {
19861983
gpiod_set_value_cansleep(peb2466->reset_gpio, 1);
@@ -2031,17 +2028,9 @@ static int peb2466_spi_probe(struct spi_device *spi)
20312028
return 0;
20322029

20332030
failed:
2034-
clk_disable_unprepare(peb2466->mclk);
20352031
return ret;
20362032
}
20372033

2038-
static void peb2466_spi_remove(struct spi_device *spi)
2039-
{
2040-
struct peb2466 *peb2466 = spi_get_drvdata(spi);
2041-
2042-
clk_disable_unprepare(peb2466->mclk);
2043-
}
2044-
20452034
static const struct of_device_id peb2466_of_match[] = {
20462035
{ .compatible = "infineon,peb2466", },
20472036
{ }
@@ -2061,7 +2050,6 @@ static struct spi_driver peb2466_spi_driver = {
20612050
},
20622051
.id_table = peb2466_id_table,
20632052
.probe = peb2466_spi_probe,
2064-
.remove = peb2466_spi_remove,
20652053
};
20662054

20672055
module_spi_driver(peb2466_spi_driver);

0 commit comments

Comments
 (0)