dm-pcache: cleanup: fix coding style report by checkpatch.pl

yangdongsheng · Mikulas Patocka · commit 247357717749 · 2025-09-01T13:30:54.000+02:00
A patch from a few days ago fixed the division issue on 32-bit machines,
but it introduced a coding style problem.

WARNING: Missing a blank line after declarations
+       u32 rem;
+       div_u64_rem(off &gt;&gt; PCACHE_CACHE_SUBTREE_SIZE_SHIFT,
	cache-&gt;n_ksets, &amp;rem);

total: 0 errors, 1 warnings, 634 lines checked

Signed-off-by: Dongsheng Yang &lt;dongsheng.yang@linux.dev&gt;
Signed-off-by: Mikulas Patocka &lt;mpatocka@redhat.com&gt;
diff --git a/drivers/md/dm-pcache/cache.h b/drivers/md/dm-pcache/cache.h
@@ -372,9 +372,11 @@ static inline void *get_key_head_addr(struct pcache_cache *cache)
 
 static inline u32 get_kset_id(struct pcache_cache *cache, u64 off)
 {
-	u32 rem;
-	div_u64_rem(off >> PCACHE_CACHE_SUBTREE_SIZE_SHIFT, cache->n_ksets, &rem);
-	return rem;
+	u32 kset_id;
+
+	div_u64_rem(off >> PCACHE_CACHE_SUBTREE_SIZE_SHIFT, cache->n_ksets, &kset_id);
+
+	return kset_id;
 }
 
 static inline struct pcache_cache_kset *get_kset(struct pcache_cache *cache, u32 kset_id)

Original file line number	Diff line number	Diff line change
`@@ -372,9 +372,11 @@ static inline void get_key_head_addr(struct pcache_cache cache)`
`372`	`372`
`373`	`373`	`static inline u32 get_kset_id(struct pcache_cache *cache, u64 off)`
`374`	`374`	`{`
`375`		`- u32 rem;`
`376`		`- div_u64_rem(off >> PCACHE_CACHE_SUBTREE_SIZE_SHIFT, cache->n_ksets, &rem);`
`377`		`- return rem;`
	`375`	`+ u32 kset_id;`
	`376`	`+`
	`377`	`+ div_u64_rem(off >> PCACHE_CACHE_SUBTREE_SIZE_SHIFT, cache->n_ksets, &kset_id);`
	`378`	`+`
	`379`	`+ return kset_id;`
`378`	`380`	`}`
`379`	`381`
`380`	`382`	`static inline struct pcache_cache_kset get_kset(struct pcache_cache cache, u32 kset_id)`