Skip to content

Commit 25742ae

Browse files
committed
ring-buffer: Remove stale comment from ring_buffer_size()
It's been 11 years since the ring_buffer_size() function was updated to use the nr_pages from the buffer->buffers[cpu] structure instead of using the buffer->nr_pages that no longer exists. The comment in the code is more of what a change log should have and is pretty much useless for development. It's saying how things worked back in 2012 that bares no purpose on today's code. Remove it. Link: https://lore.kernel.org/linux-trace-kernel/84d3b41a72bd43dbb9d44921ef535c92@AcuMS.aculab.com/ Link: https://lore.kernel.org/linux-trace-kernel/20231220081028.7cd7e8e2@gandalf.local.home Cc: Mark Rutland <mark.rutland@arm.com> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Reported-by: David Laight <David.Laight@ACULAB.COM> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
1 parent 4f1991a commit 25742ae

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

kernel/trace/ring_buffer.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5122,12 +5122,6 @@ EXPORT_SYMBOL_GPL(ring_buffer_iter_advance);
51225122
*/
51235123
unsigned long ring_buffer_size(struct trace_buffer *buffer, int cpu)
51245124
{
5125-
/*
5126-
* Earlier, this method returned
5127-
* buffer->subbuf_size * buffer->nr_pages
5128-
* Since the nr_pages field is now removed, we have converted this to
5129-
* return the per cpu buffer value.
5130-
*/
51315125
if (!cpumask_test_cpu(cpu, buffer->cpumask))
51325126
return 0;
51335127

0 commit comments

Comments
 (0)