Skip to content

Commit 257dfd9

Browse files
laeyraudChun-Kuang Hu
authored andcommitted
drm/mediatek: mtk_hdmi: Drop redundant clock retrieval in mtk_hdmi_get_cec_dev
In mtk_hdmi driver, when the CEC device parsing logic was moved from mtk_hdmi_dt_parse_pdata function to the new mtk_hdmi_get_cec_dev sub function, the call to mtk_hdmi_get_all_clk was kept in both functions, whereas it was only called once in the original mtk_hdmi_dt_parse_pdata code and does not need to be called a second time. So, remove this call from mtk_hdmi_get_cec_dev to keep the same sequence as previously. Fixes: 7485be9 ("drm/mediatek: mtk_hdmi: Move CEC device parsing in new function") Reviewed-by: CK Hu <ck.hu@mediatek.com> Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com> Link: https://patchwork.kernel.org/project/linux-mediatek/patch/20251023-mediatek-drm-hdmi-v2-v11-1-7873ec4a1edf@collabora.com/ Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
1 parent 9545bae commit 257dfd9

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

drivers/gpu/drm/mediatek/mtk_hdmi.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1358,10 +1358,6 @@ static int mtk_hdmi_get_cec_dev(struct mtk_hdmi *hdmi, struct device *dev, struc
13581358
struct device_node *cec_np;
13591359
int ret;
13601360

1361-
ret = mtk_hdmi_get_all_clk(hdmi, np);
1362-
if (ret)
1363-
return dev_err_probe(dev, ret, "Failed to get clocks\n");
1364-
13651361
/* The CEC module handles HDMI hotplug detection */
13661362
cec_np = of_get_compatible_child(np->parent, "mediatek,mt8173-cec");
13671363
if (!cec_np)

0 commit comments

Comments
 (0)