Skip to content

Commit 2910913

Browse files
author
Jiri Kosina
committed
HID: steelseries: Fix STEELSERIES_SRWS1 handling in steelseries_remove()
srws1_remove label can be only reached only if LEDS subsystem is enabled. To avoid putting horryfing ifdef second time around the label, just perform the cleanup and exit immediately directly. Fixes: a84eeac ("HID: steelseries: refactor probe() and remove()") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202509090334.76D4qGtW-lkp@intel.com/ Signed-off-by: Jiri Kosina <jkosina@suse.com>
1 parent a84eeac commit 2910913

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/hid/hid-steelseries.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,7 @@ static void steelseries_remove(struct hid_device *hdev)
582582
if (hdev->product == USB_DEVICE_ID_STEELSERIES_SRWS1) {
583583
#if IS_BUILTIN(CONFIG_LEDS_CLASS) || \
584584
(IS_MODULE(CONFIG_LEDS_CLASS) && IS_MODULE(CONFIG_HID_STEELSERIES))
585-
goto srws1_remove;
585+
hid_hw_stop(hdev);
586586
#endif
587587
return;
588588
}
@@ -596,7 +596,6 @@ static void steelseries_remove(struct hid_device *hdev)
596596
cancel_delayed_work_sync(&sd->battery_work);
597597

598598
hid_hw_close(hdev);
599-
srws1_remove:
600599
hid_hw_stop(hdev);
601600
}
602601

0 commit comments

Comments
 (0)