Skip to content

Commit 2946bac

Browse files
Niklas Söderlundhverkuil
authored andcommitted
media: i2c: imx290: Remove unneeded assignment of subdev device pointer
The core helper v4l2_i2c_subdev_init() already assignees the subdevices dev pointer to the device associated with the i2c client passed to it. And 'imx290->dev' is assigned to '&client->dev' already in probe before calling imx290_subdev_init(). Remove the duplicated open-coded assignment in the driver, there is no reason to do it twice. Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
1 parent 76142b1 commit 2946bac

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/media/i2c/imx290.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1294,7 +1294,6 @@ static int imx290_subdev_init(struct imx290 *imx290)
12941294
* will already be prevented even before the delay.
12951295
*/
12961296
v4l2_i2c_subdev_init(&imx290->sd, client, &imx290_subdev_ops);
1297-
imx290->sd.dev = imx290->dev;
12981297
pm_runtime_mark_last_busy(imx290->dev);
12991298
pm_runtime_put_autosuspend(imx290->dev);
13001299

0 commit comments

Comments
 (0)