Skip to content

Commit 298f0ae

Browse files
P Praneeshgregkh
authored andcommitted
wifi: ath12k: Fix invalid entry fetch in ath12k_dp_mon_srng_process
commit 63fdc45 upstream. Currently, ath12k_dp_mon_srng_process uses ath12k_hal_srng_src_get_next_entry to fetch the next entry from the destination ring. This is incorrect because ath12k_hal_srng_src_get_next_entry is intended for source rings, not destination rings. This leads to invalid entry fetches, causing potential data corruption or crashes due to accessing incorrect memory locations. This happens because the source ring and destination ring have different handling mechanisms and using the wrong function results in incorrect pointer arithmetic and ring management. To fix this issue, replace the call to ath12k_hal_srng_src_get_next_entry with ath12k_hal_srng_dst_get_next_entry in ath12k_dp_mon_srng_process. This ensures that the correct function is used for fetching entries from the destination ring, preventing invalid memory accesses. Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 Tested-on: WCN7850 hw2.0 WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 Signed-off-by: P Praneesh <quic_ppranees@quicinc.com> Link: https://patch.msgid.link/20241223060132.3506372-7-quic_ppranees@quicinc.com Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com> Signed-off-by: Alexander Tsoy <alexander@tsoy.me> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 43512f6 commit 298f0ae

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/net/wireless/ath/ath12k/dp_mon.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2054,7 +2054,7 @@ int ath12k_dp_mon_srng_process(struct ath12k *ar, int mac_id, int *budget,
20542054
dest_idx = 0;
20552055
move_next:
20562056
ath12k_dp_mon_buf_replenish(ab, buf_ring, 1);
2057-
ath12k_hal_srng_src_get_next_entry(ab, srng);
2057+
ath12k_hal_srng_dst_get_next_entry(ab, srng);
20582058
num_buffs_reaped++;
20592059
}
20602060

0 commit comments

Comments
 (0)