Skip to content

Commit 2e5e1a7

Browse files
jhovoldandersson
authored andcommitted
Revert "arm64: dts: qcom: x1e80100-crd: enable otg on usb ports"
This reverts commit 2dd3250. A recent change enabling OTG mode on the x1e81000 CRD breaks suspend. Specifically, the device hard resets during resume if suspended with all controllers in device mode (i.e. no USB device connected). The corresponding change on the T14s also led to SuperSpeed hotplugs not being detected. With retimer (and orientation detection) support not even merged yet, let's revert at least until we have stable host mode in mainline. Fixes: 2dd3250 ("arm64: dts: qcom: x1e80100-crd: enable otg on usb ports") Reported-by: Abel Vesa <abel.vesa@linaro.org> Cc: Jonathan Marek <jonathan@marek.ca> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Abel Vesa <abel.vesa@linaro.org> Link: https://lore.kernel.org/r/20241210111444.26240-3-johan+linaro@kernel.org Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent fb8e7b3 commit 2e5e1a7

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

arch/arm64/boot/dts/qcom/x1e80100-crd.dts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1197,6 +1197,10 @@
11971197
status = "okay";
11981198
};
11991199

1200+
&usb_1_ss0_dwc3 {
1201+
dr_mode = "host";
1202+
};
1203+
12001204
&usb_1_ss0_dwc3_hs {
12011205
remote-endpoint = <&pmic_glink_ss0_hs_in>;
12021206
};
@@ -1225,6 +1229,10 @@
12251229
status = "okay";
12261230
};
12271231

1232+
&usb_1_ss1_dwc3 {
1233+
dr_mode = "host";
1234+
};
1235+
12281236
&usb_1_ss1_dwc3_hs {
12291237
remote-endpoint = <&pmic_glink_ss1_hs_in>;
12301238
};
@@ -1253,6 +1261,10 @@
12531261
status = "okay";
12541262
};
12551263

1264+
&usb_1_ss2_dwc3 {
1265+
dr_mode = "host";
1266+
};
1267+
12561268
&usb_1_ss2_dwc3_hs {
12571269
remote-endpoint = <&pmic_glink_ss2_hs_in>;
12581270
};

0 commit comments

Comments
 (0)