Skip to content

Commit 2ee865c

Browse files
Ondrej ZaryDamien Le Moal
authored andcommitted
ata: pata_parport-bpck6: merge ppc6_rd_port into bpck6_read_regr
ppc6_rd_port is only called by bpck6_read_regr. Merge ppc6_rd_port into bpck6_read_regr. Signed-off-by: Ondrej Zary <linux@zary.sk> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
1 parent cd3b394 commit 2ee865c

2 files changed

Lines changed: 4 additions & 11 deletions

File tree

drivers/ata/pata_parport/bpck6.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@
2121

2222
static int bpck6_read_regr(struct pi_adapter *pi, int cont, int reg)
2323
{
24-
return ppc6_rd_port(pi, cont?reg|8:reg);
24+
u8 port = cont ? reg | 8 : reg;
25+
26+
ppc6_send_cmd(pi, port | ACCESS_PORT | ACCESS_READ);
27+
return ppc6_rd_data_byte(pi);
2528
}
2629

2730
static void bpck6_write_regr(struct pi_adapter *pi, int cont, int reg, int val)

drivers/ata/pata_parport/ppc6lnx.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ static void ppc6_deselect(struct pi_adapter *pi);
7272
static void ppc6_send_cmd(struct pi_adapter *pi, u8 cmd);
7373
static void ppc6_wr_data_byte(struct pi_adapter *pi, u8 data);
7474
static u8 ppc6_rd_data_byte(struct pi_adapter *pi);
75-
static u8 ppc6_rd_port(struct pi_adapter *pi, u8 port);
7675
static void ppc6_wr_port(struct pi_adapter *pi, u8 port, u8 data);
7776
static void ppc6_rd_data_blk(struct pi_adapter *pi, u8 *data, long count);
7877
static void ppc6_wait_for_fifo(struct pi_adapter *pi);
@@ -288,15 +287,6 @@ static u8 ppc6_rd_data_byte(struct pi_adapter *pi)
288287

289288
//***************************************************************************
290289

291-
static u8 ppc6_rd_port(struct pi_adapter *pi, u8 port)
292-
{
293-
ppc6_send_cmd(pi, port | ACCESS_PORT | ACCESS_READ);
294-
295-
return ppc6_rd_data_byte(pi);
296-
}
297-
298-
//***************************************************************************
299-
300290
static void ppc6_wr_port(struct pi_adapter *pi, u8 port, u8 data)
301291
{
302292
ppc6_send_cmd(pi, port | ACCESS_PORT | ACCESS_WRITE);

0 commit comments

Comments
 (0)