Skip to content

Commit 2fe4b6a

Browse files
Justin Teemartinkpetersen
authored andcommitted
scsi: lpfc: Correct maximum PCI function value for RAS fw logging
Currently, the ras_fwlog_func sysfs parameter allows users to input a value greater than three when selecting a PCI function to enable RAS fw logging feature. The user's input is sanity checked in lpfc_sli4_ras_init(), but allowing an input greater than three doesn't make sense because the max number of ports per HBA is four. Change the allowable range from [0, 7] to [0, 3]. Signed-off-by: Justin Tee <justin.tee@broadcom.com> Link: https://lore.kernel.org/r/20231031191224.150862-2-justintee8345@gmail.com Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent b85ea95 commit 2fe4b6a

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/scsi/lpfc/lpfc_attr.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5905,11 +5905,11 @@ LPFC_ATTR_RW(ras_fwlog_level, 0, 0, 4, "Firmware Logging Level");
59055905
/*
59065906
* lpfc_ras_fwlog_func: Firmware logging enabled on function number
59075907
* Default function which has RAS support : 0
5908-
* Value Range is [0..7].
5908+
* Value Range is [0..3].
59095909
* FW logging is a global action and enablement is via a specific
59105910
* port.
59115911
*/
5912-
LPFC_ATTR_RW(ras_fwlog_func, 0, 0, 7, "Firmware Logging Enabled on Function");
5912+
LPFC_ATTR_RW(ras_fwlog_func, 0, 0, 3, "Firmware Logging Enabled on Function");
59135913

59145914
/*
59155915
* lpfc_enable_bbcr: Enable BB Credit Recovery

0 commit comments

Comments
 (0)