Skip to content

Commit 30531e9

Browse files
jlawrynokwachows
authored andcommitted
accel/ivpu: Improve BO alloc/free warnings
Add additional warnings related to allocation and deallocation of buffer objects to better track possible memory leaks and generally the BO's lifecycle. Introduce checks for handle_count to ensure it is zero before creating a new handle, and exactly one after successfully creating a handle. Introduce also a check to warn if the VMA node is not empty when freeing the buffer object. Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> Signed-off-by: Maciej Falkowski <maciej.falkowski@linux.intel.com> Reviewed-by: Karol Wachowski <karol.wachowski@linux.intel.com> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com> Link: https://lore.kernel.org/r/20250925145154.1446427-1-maciej.falkowski@linux.intel.com
1 parent 9f56275 commit 30531e9

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

drivers/accel/ivpu/ivpu_gem.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,6 +332,7 @@ static void ivpu_gem_bo_free(struct drm_gem_object *obj)
332332
drm_WARN_ON(&vdev->drm, bo->ctx);
333333

334334
drm_WARN_ON(obj->dev, refcount_read(&bo->base.pages_use_count) > 1);
335+
drm_WARN_ON(obj->dev, bo->base.base.vma_node.vm_files.rb_node);
335336
drm_gem_shmem_free(&bo->base);
336337
}
337338

@@ -370,12 +371,16 @@ int ivpu_bo_create_ioctl(struct drm_device *dev, void *data, struct drm_file *fi
370371
return PTR_ERR(bo);
371372
}
372373

374+
drm_WARN_ON(&vdev->drm, bo->base.base.handle_count != 0);
375+
373376
ret = drm_gem_handle_create(file, &bo->base.base, &args->handle);
374-
if (ret)
377+
if (ret) {
375378
ivpu_err(vdev, "Failed to create handle for BO: %pe (ctx %u size %llu flags 0x%x)",
376379
bo, file_priv->ctx.id, args->size, args->flags);
377-
else
380+
} else {
378381
args->vpu_addr = bo->vpu_addr;
382+
drm_WARN_ON(&vdev->drm, bo->base.base.handle_count != 1);
383+
}
379384

380385
drm_gem_object_put(&bo->base.base);
381386

0 commit comments

Comments
 (0)