Skip to content

Commit 3070d3e

Browse files
andredjannau
authored andcommitted
tty: serial: samsung_tty: drop unused argument to irq handlers
The 'irq' argument is not used in any of the callees, we can just drop it and simplify the code. No functional changes. Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> Signed-off-by: André Draszik <andre.draszik@linaro.org> Reviewed-by: Jiri Slaby <jirislaby@kernel.org> Link: https://lore.kernel.org/r/20240808-samsung-tty-cleanup-v3-1-494412f49f4b@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 9503421 commit 3070d3e

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

drivers/tty/serial/samsung_tty.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -855,7 +855,7 @@ static irqreturn_t s3c24xx_serial_rx_chars_pio(void *dev_id)
855855
return IRQ_HANDLED;
856856
}
857857

858-
static irqreturn_t s3c24xx_serial_rx_irq(int irq, void *dev_id)
858+
static irqreturn_t s3c24xx_serial_rx_irq(void *dev_id)
859859
{
860860
struct s3c24xx_uart_port *ourport = dev_id;
861861

@@ -928,7 +928,7 @@ static void s3c24xx_serial_tx_chars(struct s3c24xx_uart_port *ourport)
928928
s3c24xx_serial_stop_tx(port);
929929
}
930930

931-
static irqreturn_t s3c24xx_serial_tx_irq(int irq, void *id)
931+
static irqreturn_t s3c24xx_serial_tx_irq(void *id)
932932
{
933933
struct s3c24xx_uart_port *ourport = id;
934934
struct uart_port *port = &ourport->port;
@@ -950,11 +950,11 @@ static irqreturn_t s3c64xx_serial_handle_irq(int irq, void *id)
950950
irqreturn_t ret = IRQ_HANDLED;
951951

952952
if (pend & S3C64XX_UINTM_RXD_MSK) {
953-
ret = s3c24xx_serial_rx_irq(irq, id);
953+
ret = s3c24xx_serial_rx_irq(id);
954954
wr_regl(port, S3C64XX_UINTP, S3C64XX_UINTM_RXD_MSK);
955955
}
956956
if (pend & S3C64XX_UINTM_TXD_MSK) {
957-
ret = s3c24xx_serial_tx_irq(irq, id);
957+
ret = s3c24xx_serial_tx_irq(id);
958958
wr_regl(port, S3C64XX_UINTP, S3C64XX_UINTM_TXD_MSK);
959959
}
960960
return ret;
@@ -971,11 +971,11 @@ static irqreturn_t apple_serial_handle_irq(int irq, void *id)
971971
if (pend & (APPLE_S5L_UTRSTAT_RXTHRESH | APPLE_S5L_UTRSTAT_RXTO)) {
972972
wr_regl(port, S3C2410_UTRSTAT,
973973
APPLE_S5L_UTRSTAT_RXTHRESH | APPLE_S5L_UTRSTAT_RXTO);
974-
ret = s3c24xx_serial_rx_irq(irq, id);
974+
ret = s3c24xx_serial_rx_irq(id);
975975
}
976976
if (pend & APPLE_S5L_UTRSTAT_TXTHRESH) {
977977
wr_regl(port, S3C2410_UTRSTAT, APPLE_S5L_UTRSTAT_TXTHRESH);
978-
ret = s3c24xx_serial_tx_irq(irq, id);
978+
ret = s3c24xx_serial_tx_irq(id);
979979
}
980980

981981
return ret;

0 commit comments

Comments
 (0)