udf: d_splice_alias() will do the right thing on ERR_PTR() inode

Al Viro · Al Viro · commit 32328a73e0ad · 2023-12-21T12:49:16.000-05:00
Acked-by: Jan Kara &lt;jack@suse.cz&gt;
Signed-off-by: Al Viro &lt;viro@zeniv.linux.org.uk&gt;
diff --git a/fs/udf/namei.c b/fs/udf/namei.c
@@ -125,8 +125,6 @@ static struct dentry *udf_lookup(struct inode *dir, struct dentry *dentry,
 		udf_fiiter_release(&iter);
 
 		inode = udf_iget(dir->i_sb, &loc);
-		if (IS_ERR(inode))
-			return ERR_CAST(inode);
 	}
 
 	return d_splice_alias(inode, dentry);

Original file line number	Diff line number	Diff line change
`@@ -125,8 +125,6 @@ static struct dentry udf_lookup(struct inode dir, struct dentry *dentry,`
`125`	`125`	`udf_fiiter_release(&iter);`
`126`	`126`
`127`	`127`	`inode = udf_iget(dir->i_sb, &loc);`
`128`		`- if (IS_ERR(inode))`
`129`		`- return ERR_CAST(inode);`
`130`	`128`	`}`
`131`	`129`
`132`	`130`	`return d_splice_alias(inode, dentry);`