extcon: qcom-spmi-misc: Fix wakeup source leaks on device unbind

krzk · chanwoochoi · commit 369259d5104d · 2025-08-26T19:51:36.000+09:00
Device can be unbound, so driver must also release memory for the wakeup source. Link: https://lore.kernel.org/lkml/20250501-device-wakeup-leak-extcon-v2-4-7af77802cbea@linaro.org/ Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
diff --git a/drivers/extcon/extcon-qcom-spmi-misc.c b/drivers/extcon/extcon-qcom-spmi-misc.c
@@ -155,7 +155,7 @@ static int qcom_usb_extcon_probe(struct platform_device *pdev)
 	}
 
 	platform_set_drvdata(pdev, info);
-	device_init_wakeup(dev, 1);
+	devm_device_init_wakeup(dev);
 
 	/* Perform initial detection */
 	qcom_usb_extcon_detect_cable(&info->wq_detcable.work);

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ static int qcom_usb_extcon_probe(struct platform_device *pdev)`
`155`	`155`	`}`
`156`	`156`
`157`	`157`	`platform_set_drvdata(pdev, info);`
`158`		`- device_init_wakeup(dev, 1);`
	`158`	`+ devm_device_init_wakeup(dev);`
`159`	`159`
`160`	`160`	`/* Perform initial detection */`
`161`	`161`	`qcom_usb_extcon_detect_cable(&info->wq_detcable.work);`