Skip to content

Commit 384bd58

Browse files
ISCAS-Vulablag-linaro
authored andcommitted
mfd: mt6358-irq: Fix missing irq_domain_remove() in error path
If devm_request_threaded_irq() fails after irq_domain_add_linear() succeeds in mt6358_irq_init(), the function returns without removing the created IRQ domain, leading to a resource leak. Call irq_domain_remove() in the error path after a successful irq_domain_add_linear() to properly release the IRQ domain. Fixes: 2b91c28 ("mfd: Add support for the MediaTek MT6358 PMIC") Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn> Link: https://patch.msgid.link/20251118121427.583-1-vulab@iscas.ac.cn Signed-off-by: Lee Jones <lee@kernel.org>
1 parent b4b1bd1 commit 384bd58

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/mfd/mt6358-irq.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -285,6 +285,7 @@ int mt6358_irq_init(struct mt6397_chip *chip)
285285
if (ret) {
286286
dev_err(chip->dev, "Failed to register IRQ=%d, ret=%d\n",
287287
chip->irq, ret);
288+
irq_domain_remove(chip->irq_domain);
288289
return ret;
289290
}
290291

0 commit comments

Comments
 (0)