Skip to content

Commit 38f4885

Browse files
author
Al Viro
committed
mnt_ns_tree_remove(): DTRT if mnt_ns had never been added to mnt_ns_list
Actual removal is done under the lock, but for checking if need to bother the lockless RB_EMPTY_NODE() is safe - either that namespace had never been added to mnt_ns_tree, in which case the the node will stay empty, or whoever had allocated it has called mnt_ns_tree_add() and it has already run to completion. After that point RB_EMPTY_NODE() will become false and will remain false, no matter what we do with other nodes in the tree. Reviewed-by: Christian Brauner <brauner@kernel.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
1 parent b320789 commit 38f4885

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/namespace.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ static void mnt_ns_release_rcu(struct rcu_head *rcu)
187187
static void mnt_ns_tree_remove(struct mnt_namespace *ns)
188188
{
189189
/* remove from global mount namespace list */
190-
if (!is_anon_ns(ns)) {
190+
if (!RB_EMPTY_NODE(&ns->mnt_ns_tree_node)) {
191191
mnt_ns_tree_write_lock();
192192
rb_erase(&ns->mnt_ns_tree_node, &mnt_ns_tree);
193193
list_bidir_del_rcu(&ns->mnt_ns_list);

0 commit comments

Comments
 (0)