Skip to content

Commit 3967def

Browse files
Ondrej ZaryDamien Le Moal
authored andcommitted
ata: pata_parport-bpck6: merge ppc6_rd_port16_blk into bpck6_read_block
ppc6_rd_port16_blk is only called by bpck6_read_block. Merge ppc6_rd_port16_blk into bpck6_read_block. Signed-off-by: Ondrej Zary <linux@zary.sk> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
1 parent ba98c56 commit 3967def

2 files changed

Lines changed: 9 additions & 22 deletions

File tree

drivers/ata/pata_parport/bpck6.c

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,15 @@ static void bpck6_write_block(struct pi_adapter *pi, char *buf, int len)
4242

4343
static void bpck6_read_block(struct pi_adapter *pi, char *buf, int len)
4444
{
45-
ppc6_rd_port16_blk(pi, ATA_REG_DATA, buf, (u32)len>>1);
45+
ppc6_send_cmd(pi, REG_BLKSIZE | ACCESS_REG | ACCESS_WRITE);
46+
ppc6_wr_data_byte(pi, (u8)len);
47+
ppc6_wr_data_byte(pi, (u8)(len >> 8));
48+
ppc6_wr_data_byte(pi, 0);
49+
50+
ppc6_send_cmd(pi, CMD_PREFIX_SET | PREFIX_IO16 | PREFIX_BLK);
51+
ppc6_send_cmd(pi, ATA_REG_DATA | ACCESS_PORT | ACCESS_READ);
52+
ppc6_rd_data_blk(pi, buf, len);
53+
ppc6_send_cmd(pi, CMD_PREFIX_RESET | PREFIX_IO16 | PREFIX_BLK);
4654
}
4755

4856
static void bpck6_connect(struct pi_adapter *pi)

drivers/ata/pata_parport/ppc6lnx.c

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ static u8 ppc6_rd_data_byte(struct pi_adapter *pi);
7575
static void ppc6_rd_data_blk(struct pi_adapter *pi, u8 *data, long count);
7676
static void ppc6_wait_for_fifo(struct pi_adapter *pi);
7777
static void ppc6_wr_data_blk(struct pi_adapter *pi, u8 *data, long count);
78-
static void ppc6_rd_port16_blk(struct pi_adapter *pi, u8 port, u8 *data, long length);
7978
static void ppc6_wr_port16_blk(struct pi_adapter *pi, u8 port, u8 *data, long length);
8079
static void ppc6_wr_extout(struct pi_adapter *pi, u8 regdata);
8180
static int ppc6_open(struct pi_adapter *pi);
@@ -479,26 +478,6 @@ static void ppc6_wr_data_blk(struct pi_adapter *pi, u8 *data, long count)
479478

480479
//***************************************************************************
481480

482-
static void ppc6_rd_port16_blk(struct pi_adapter *pi, u8 port, u8 *data, long length)
483-
{
484-
length = length << 1;
485-
486-
ppc6_send_cmd(pi, REG_BLKSIZE | ACCESS_REG | ACCESS_WRITE);
487-
ppc6_wr_data_byte(pi, (u8)length);
488-
ppc6_wr_data_byte(pi, (u8)(length >> 8));
489-
ppc6_wr_data_byte(pi, 0);
490-
491-
ppc6_send_cmd(pi, CMD_PREFIX_SET | PREFIX_IO16 | PREFIX_BLK);
492-
493-
ppc6_send_cmd(pi, port | ACCESS_PORT | ACCESS_READ);
494-
495-
ppc6_rd_data_blk(pi, data, length);
496-
497-
ppc6_send_cmd(pi, CMD_PREFIX_RESET | PREFIX_IO16 | PREFIX_BLK);
498-
}
499-
500-
//***************************************************************************
501-
502481
static void ppc6_wr_port16_blk(struct pi_adapter *pi, u8 port, u8 *data, long length)
503482
{
504483
length = length << 1;

0 commit comments

Comments
 (0)