Skip to content

Commit 3a1fb52

Browse files
Matthias Fetzerjwrdegoede
authored andcommitted
platform/x86: thinkpad_acpi: Fix uninitialized symbol 's' warning
When the TPACPI_FAN_WR_ACPI_FANW branch is taken s stays uninitialized and would be later used in a debug print. Since the registers are always set to the same two static values inside the branch s is initialized to 0. Fixes: 57d0557 ("platform/x86: thinkpad_acpi: Add Thinkpad Edge E531 fan support") Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/platform-driver-x86/f99e558d-c62a-41eb-93b3-cf00c016d907@stanley.mountain/ Signed-off-by: Matthias Fetzer <kontakt@matthias-fetzer.de> Link: https://lore.kernel.org/r/20240903172756.19235-1-kontakt@matthias-fetzer.de Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
1 parent bb9c2e5 commit 3a1fb52

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/platform/x86/thinkpad_acpi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8318,7 +8318,7 @@ static int fan_set_level_safe(int level)
83188318

83198319
static int fan_set_enable(void)
83208320
{
8321-
u8 s;
8321+
u8 s = 0;
83228322
int rc;
83238323

83248324
if (!fan_control_allowed)

0 commit comments

Comments
 (0)