Skip to content

Commit 3a20c44

Browse files
can: bxcan: bxcan_start_xmit(): use can_dev_dropped_skb() instead of can_dropped_invalid_skb()
In addition to can_dropped_invalid_skb(), the helper function can_dev_dropped_skb() checks whether the device is in listen-only mode and discards the skb accordingly. Replace can_dropped_invalid_skb() by can_dev_dropped_skb() to also drop skbs in for listen-only mode. Reported-by: Marc Kleine-Budde <mkl@pengutronix.de> Closes: https://lore.kernel.org/all/20251017-bizarre-enchanted-quokka-f3c704-mkl@pengutronix.de/ Fixes: f00647d ("can: bxcan: add support for ST bxCAN controller") Link: https://patch.msgid.link/20251017-fix-skb-drop-check-v1-1-556665793fa4@pengutronix.de Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
1 parent ffff5c8 commit 3a20c44

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/net/can/bxcan.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -842,7 +842,7 @@ static netdev_tx_t bxcan_start_xmit(struct sk_buff *skb,
842842
u32 id;
843843
int i, j;
844844

845-
if (can_dropped_invalid_skb(ndev, skb))
845+
if (can_dev_dropped_skb(ndev, skb))
846846
return NETDEV_TX_OK;
847847

848848
if (bxcan_tx_busy(priv))

0 commit comments

Comments
 (0)