Skip to content

Commit 3b86c87

Browse files
Benjamin TissoiresJiri Kosina
authored andcommitted
HID: bpf: fix typo in HID usage table
We could go to the USB consortium, but it's probably easier that way. And update HID usage table json generated file from https://usb.org/sites/default/files/hut1_6.pdf updated: 01/30/2025 Reported-by: Colin Ian King <colin.i.king@gmail.com> Link: https://gitlab.freedesktop.org/libevdev/udev-hid-bpf/-/merge_requests/191 Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com> Signed-off-by: Benjamin Tissoires <bentiss@kernel.org> Signed-off-by: Jiri Kosina <jkosina@suse.com>
1 parent 71570e8 commit 3b86c87

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

drivers/hid/bpf/progs/hid_report_helpers.h

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,11 @@
143143
* report with Report ID 0xac of the given size in bytes.
144144
* The size is inclusive of the 1 byte Report ID prefix.
145145
*
146-
* HID-BPF requires that at least one report has
147-
* the same size as the original report from the device.
146+
* The kernel discards any HID reports that are larger
147+
* than the largest report in a HID report descriptor.
148+
* Thus at least one report must have (at least)
149+
* the same size as the largest original report from
150+
* the device.
148151
* The easy way to ensure that is to add this
149152
* macro as the last element of your CollectionApplication
150153
* other reports can be of any size less than this.
@@ -295,6 +298,7 @@
295298
#define Usage_GD_SystemSpeakerMute Usage_i8(0xa7)
296299
#define Usage_GD_SystemHibernate Usage_i8(0xa8)
297300
#define Usage_GD_SystemMicrophoneMute Usage_i8(0xa9)
301+
#define Usage_GD_SystemAccessibilityBinding Usage_i8(0xaa)
298302
#define Usage_GD_SystemDisplayInvert Usage_i8(0xb0)
299303
#define Usage_GD_SystemDisplayInternal Usage_i8(0xb1)
300304
#define Usage_GD_SystemDisplayExternal Usage_i8(0xb2)
@@ -2669,7 +2673,7 @@
26692673
#define Usage_BS_iDeviceName Usage_i8(0x88)
26702674
#define Usage_BS_iDeviceChemistry Usage_i8(0x89)
26712675
#define Usage_BS_ManufacturerData Usage_i8(0x8a)
2672-
#define Usage_BS_Rechargable Usage_i8(0x8b)
2676+
#define Usage_BS_Rechargeable Usage_i8(0x8b)
26732677
#define Usage_BS_WarningCapacityLimit Usage_i8(0x8c)
26742678
#define Usage_BS_CapacityGranularity1 Usage_i8(0x8d)
26752679
#define Usage_BS_CapacityGranularity2 Usage_i8(0x8e)

0 commit comments

Comments
 (0)