gpio: regmap: fix memory leak of gpio_regmap structure

IoanaCiornei · Bartosz Golaszewski · commit 3bd44edd6c55 · 2025-09-22T16:35:21.000+02:00
The gpio_regmap structure is leaked on the error path. Fix this by jumping to the appropriate kfree instead of returning directly. Fixes: db30516 ("gpio: regmap: Allow ngpio to be read from the property") Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> Suggested-by: Michael Walle <mwalle@kernel.org> Reviewed-by: Michael Walle <mwalle@kernel.org> Link: https://lore.kernel.org/r/20250922142427.3310221-7-ioana.ciornei@nxp.com Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
diff --git a/drivers/gpio/gpio-regmap.c b/drivers/gpio/gpio-regmap.c
@@ -274,7 +274,7 @@ struct gpio_regmap *gpio_regmap_register(const struct gpio_regmap_config *config
 	if (!chip->ngpio) {
 		ret = gpiochip_get_ngpios(chip, chip->parent);
 		if (ret)
-			return ERR_PTR(ret);
+			goto err_free_gpio;
 	}
 
 	/* if not set, assume there is only one register */

Original file line number	Diff line number	Diff line change
`@@ -274,7 +274,7 @@ struct gpio_regmap gpio_regmap_register(const struct gpio_regmap_config config`
`274`	`274`	`if (!chip->ngpio) {`
`275`	`275`	`ret = gpiochip_get_ngpios(chip, chip->parent);`
`276`	`276`	`if (ret)`
`277`		`- return ERR_PTR(ret);`
	`277`	`+ goto err_free_gpio;`
`278`	`278`	`}`
`279`	`279`
`280`	`280`	`/* if not set, assume there is only one register */`