ASoC: amd: acp: Return in-case of error

Muhammad Usama Anjum · broonie · commit 3c5a18a10a8c · 2024-09-06T12:27:54.000+01:00
Return when error occurs instead of proceeding to for loop which will use val uninitialized. Fixes: f6f7d25 ("ASoC: amd: acp: Add pte configuration for ACP7.0 platform") Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Link: https://patch.msgid.link/20240906103727.222749-1-usama.anjum@collabora.com Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c
@@ -231,7 +231,7 @@ void config_acp_dma(struct acp_dev_data *adata, struct acp_stream *stream, int s
 			break;
 		default:
 			dev_err(adata->dev, "Invalid dai id %x\n", stream->dai_id);
-			break;
+			return;
 		}
 		break;
 	default:

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,7 @@ void config_acp_dma(struct acp_dev_data adata, struct acp_stream stream, int s`
`231`	`231`	`break;`
`232`	`232`	`default:`
`233`	`233`	`dev_err(adata->dev, "Invalid dai id %x\n", stream->dai_id);`
`234`		`- break;`
	`234`	`+ return;`
`235`	`235`	`}`
`236`	`236`	`break;`
`237`	`237`	`default:`