HID: mcp-2221: cancel delayed_work only when CONFIG_IIO is enabled

AbdelrahmanMorsy · Jiri Kosina · commit 3cba9cfcc152 · 2024-04-12T17:48:53.000+02:00
If the device is unplugged and CONFIG_IIO is not supported, this will
result in a warning message at kernel/workqueue.

Only cancel delayed work in mcp2221_remove(), when CONFIG_IIO is enabled.

Signed-off-by: Abdelrahman Morsy &lt;abdelrahmanhesham94@gmail.com&gt;
Signed-off-by: Jiri Kosina &lt;jkosina@suse.com&gt;
diff --git a/drivers/hid/hid-mcp2221.c b/drivers/hid/hid-mcp2221.c
@@ -944,9 +944,11 @@ static void mcp2221_hid_unregister(void *ptr)
 /* This is needed to be sure hid_hw_stop() isn't called twice by the subsystem */
 static void mcp2221_remove(struct hid_device *hdev)
 {
+#if IS_REACHABLE(CONFIG_IIO)
 	struct mcp2221 *mcp = hid_get_drvdata(hdev);
 
 	cancel_delayed_work_sync(&mcp->init_work);
+#endif
 }
 
 #if IS_REACHABLE(CONFIG_IIO)

Original file line number	Diff line number	Diff line change
`@@ -944,9 +944,11 @@ static void mcp2221_hid_unregister(void *ptr)`
`944`	`944`	`/* This is needed to be sure hid_hw_stop() isn't called twice by the subsystem */`
`945`	`945`	`static void mcp2221_remove(struct hid_device *hdev)`
`946`	`946`	`{`
	`947`	`+#if IS_REACHABLE(CONFIG_IIO)`
`947`	`948`	`struct mcp2221 *mcp = hid_get_drvdata(hdev);`
`948`	`949`
`949`	`950`	`cancel_delayed_work_sync(&mcp->init_work);`
	`951`	`+#endif`
`950`	`952`	`}`
`951`	`953`
`952`	`954`	`#if IS_REACHABLE(CONFIG_IIO)`