Skip to content

Commit 3d20d7b

Browse files
committed
drm: apple: iomfb: Use drm_kms_helper_connector_hotplug_event
Avoid device wide hotplugs as DCP knowns the affected connector. Signed-off-by: Janne Grunau <j@jannau.net>
1 parent 1da8438 commit 3d20d7b

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

drivers/gpu/drm/apple/iomfb.c

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -229,11 +229,9 @@ void dcp_ack(struct apple_dcp *dcp, enum dcp_context_id context)
229229
void dcp_hotplug(struct work_struct *work)
230230
{
231231
struct apple_connector *connector;
232-
struct drm_device *dev;
233232
struct apple_dcp *dcp;
234233

235234
connector = container_of(work, struct apple_connector, hotplug_wq);
236-
dev = connector->base.dev;
237235

238236
dcp = platform_get_drvdata(connector->dcp);
239237
dev_info(dcp->dev, "%s() connected:%d valid_mode:%d\n", __func__,
@@ -244,13 +242,11 @@ void dcp_hotplug(struct work_struct *work)
244242
* display modes from atomic_flush, so userspace needs to trigger a
245243
* flush, or the CRTC gets no signal.
246244
*/
247-
if (connector->base.state && !dcp->valid_mode && connector->connected) {
248-
drm_connector_set_link_status_property(
249-
&connector->base, DRM_MODE_LINK_STATUS_BAD);
250-
}
245+
if (connector->base.state && !dcp->valid_mode && connector->connected)
246+
drm_connector_set_link_status_property(&connector->base,
247+
DRM_MODE_LINK_STATUS_BAD);
251248

252-
if (dev && dev->registered)
253-
drm_kms_helper_hotplug_event(dev);
249+
drm_kms_helper_connector_hotplug_event(&connector->base);
254250
}
255251
EXPORT_SYMBOL_GPL(dcp_hotplug);
256252

0 commit comments

Comments
 (0)