Skip to content

Commit 3ee6c4b

Browse files
Eric BiggersMikulas Patocka
authored andcommitted
dm-verity: remove log message with shash driver name
I added this log message in commit bbf6a56 ("dm verity: log the hash algorithm implementation"), to help people debug issues where they forgot to enable the architecture-optimized SHA-256 code in their kconfig or accidentally enabled a slow hardware offload driver (such as QCE) that overrode the faster CPU-accelerated code. However: - The crypto layer now always enables the architecture-optimized SHA-1, SHA-256, and SHA-512 code. Moreover, for simplicity the driver name is now fixed at "sha1-lib", "sha256-lib", etc. - dm-verity now uses crypto_shash instead of crypto_ahash, preventing the mistake of accidentally using a slow driver such as QCE. Therefore, this log message generally no longer provides useful information. Remove it. Signed-off-by: Eric Biggers <ebiggers@kernel.org> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
1 parent be4addb commit 3ee6c4b

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/md/dm-verity-target.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1252,7 +1252,6 @@ static int verity_setup_hash_alg(struct dm_verity *v, const char *alg_name)
12521252
}
12531253
v->shash_tfm = shash;
12541254
v->digest_size = crypto_shash_digestsize(shash);
1255-
DMINFO("%s using \"%s\"", alg_name, crypto_shash_driver_name(shash));
12561255
if ((1 << v->hash_dev_block_bits) < v->digest_size * 2) {
12571256
ti->error = "Digest size too big";
12581257
return -EINVAL;

0 commit comments

Comments
 (0)