Skip to content

Commit 3f2571f

Browse files
hegdevasantjoergroedel
authored andcommitted
iommu/amd: Remove redundant domain flush from attach_device()
Domain flush was introduced in attach_device() path to handle kdump scenario. Later init code was enhanced to handle kdump scenario where it also takes care of flushing everything including TLB (see early_enable_iommus()). Hence remove redundant flush from attach_device() function. Signed-off-by: Vasant Hegde <vasant.hegde@amd.com> Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20231122090215.6191-3-vasant.hegde@amd.com Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent af32637 commit 3f2571f

1 file changed

Lines changed: 0 additions & 9 deletions

File tree

drivers/iommu/amd/iommu.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1896,15 +1896,6 @@ static int attach_device(struct device *dev,
18961896

18971897
do_attach(dev_data, domain);
18981898

1899-
/*
1900-
* We might boot into a crash-kernel here. The crashed kernel
1901-
* left the caches in the IOMMU dirty. So we have to flush
1902-
* here to evict all dirty stuff.
1903-
*/
1904-
amd_iommu_domain_flush_tlb_pde(domain);
1905-
1906-
amd_iommu_domain_flush_complete(domain);
1907-
19081899
out:
19091900
spin_unlock(&dev_data->lock);
19101901

0 commit comments

Comments
 (0)