Skip to content

Commit 3fccfa5

Browse files
author
Bartosz Golaszewski
committed
gpio: adp5585: use new line value setter callbacks
struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Acked-by: Michael Hennerich <michael.hennerich@analog.com> Link: https://lore.kernel.org/r/20250303-gpiochip-set-conversion-v1-6-1d5cceeebf8b@linaro.org Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
1 parent 8a9bc5a commit 3fccfa5

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

drivers/gpio/gpio-adp5585.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,14 +86,16 @@ static int adp5585_gpio_get_value(struct gpio_chip *chip, unsigned int off)
8686
return !!(val & bit);
8787
}
8888

89-
static void adp5585_gpio_set_value(struct gpio_chip *chip, unsigned int off, int val)
89+
static int adp5585_gpio_set_value(struct gpio_chip *chip, unsigned int off,
90+
int val)
9091
{
9192
struct adp5585_gpio_dev *adp5585_gpio = gpiochip_get_data(chip);
9293
unsigned int bank = ADP5585_BANK(off);
9394
unsigned int bit = ADP5585_BIT(off);
9495

95-
regmap_update_bits(adp5585_gpio->regmap, ADP5585_GPO_DATA_OUT_A + bank,
96-
bit, val ? bit : 0);
96+
return regmap_update_bits(adp5585_gpio->regmap,
97+
ADP5585_GPO_DATA_OUT_A + bank,
98+
bit, val ? bit : 0);
9799
}
98100

99101
static int adp5585_gpio_set_bias(struct adp5585_gpio_dev *adp5585_gpio,
@@ -192,7 +194,7 @@ static int adp5585_gpio_probe(struct platform_device *pdev)
192194
gc->direction_input = adp5585_gpio_direction_input;
193195
gc->direction_output = adp5585_gpio_direction_output;
194196
gc->get = adp5585_gpio_get_value;
195-
gc->set = adp5585_gpio_set_value;
197+
gc->set_rv = adp5585_gpio_set_value;
196198
gc->set_config = adp5585_gpio_set_config;
197199
gc->can_sleep = true;
198200

0 commit comments

Comments
 (0)