Skip to content

Commit 400fa37

Browse files
author
Trond Myklebust
committed
Revert "nfs: ignore SB_RDONLY when remounting nfs"
This reverts commit 80c4de6. Silently ignoring the "ro" and "rw" mount options causes user confusion, and regressions. Reported-by: Alkis Georgopoulos<alkisg@gmail.com> Cc: Li Lingfeng <lilingfeng3@huawei.com> Fixes: 80c4de6 ("nfs: ignore SB_RDONLY when remounting nfs") Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
1 parent b6d2a52 commit 400fa37

1 file changed

Lines changed: 0 additions & 10 deletions

File tree

fs/nfs/super.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1051,16 +1051,6 @@ int nfs_reconfigure(struct fs_context *fc)
10511051

10521052
sync_filesystem(sb);
10531053

1054-
/*
1055-
* The SB_RDONLY flag has been removed from the superblock during
1056-
* mounts to prevent interference between different filesystems.
1057-
* Similarly, it is also necessary to ignore the SB_RDONLY flag
1058-
* during reconfiguration; otherwise, it may also result in the
1059-
* creation of redundant superblocks when mounting a directory with
1060-
* different rw and ro flags multiple times.
1061-
*/
1062-
fc->sb_flags_mask &= ~SB_RDONLY;
1063-
10641054
/*
10651055
* Userspace mount programs that send binary options generally send
10661056
* them populated with default values. We have no way to know which

0 commit comments

Comments
 (0)