Skip to content

Commit 41bba99

Browse files
qianfengrongbebarino
authored andcommitted
clk: ep93xx: Use int type to store negative error codes
Change the 'ret' variable in ep93xx_uart_clock_init() from unsigned int to int, as it needs to store either negative error codes or zero. Storing the negative error codes in unsigned type, doesn't cause an issue at runtime but can be confusing. Additionally, assigning negative error codes to unsigned type may trigger a GCC warning when the -Wsign-conversion flag is enabled. No effect on runtime. Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent b52297f commit 41bba99

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/clk/clk-ep93xx.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -486,9 +486,10 @@ static const struct ep93xx_gate ep93xx_uarts[] = {
486486
static int ep93xx_uart_clock_init(struct ep93xx_clk_priv *priv)
487487
{
488488
struct clk_parent_data parent_data = { };
489-
unsigned int i, idx, ret, clk_uart_div;
489+
unsigned int i, idx, clk_uart_div;
490490
struct ep93xx_clk *clk;
491491
u32 val;
492+
int ret;
492493

493494
regmap_read(priv->map, EP93XX_SYSCON_PWRCNT, &val);
494495
if (val & EP93XX_SYSCON_PWRCNT_UARTBAUD)

0 commit comments

Comments
 (0)