Skip to content

Commit 42efa35

Browse files
Jiawen Wukuba-moo
authored andcommitted
net: libwx: Fix FW mailbox reply timeout
For the new SW-FW interaction, the timeout waiting for the firmware to return is too short. So that some mailbox commands cannot be completed. Use the 'timeout' parameter instead of fixed timeout value for flexible configuration. Fixes: 2e5af6b ("net: txgbe: Add basic support for new AML devices") Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/5D5BDE3EA501BDB8+20250513021009.145708-3-jiawenwu@trustnetic.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 141a8de commit 42efa35

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

  • drivers/net/ethernet/wangxun/libwx

drivers/net/ethernet/wangxun/libwx/wx_hw.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -434,8 +434,8 @@ static int wx_host_interface_command_r(struct wx *wx, u32 *buffer,
434434
wr32m(wx, WX_SW2FW_MBOX_CMD, WX_SW2FW_MBOX_CMD_VLD, WX_SW2FW_MBOX_CMD_VLD);
435435

436436
/* polling reply from FW */
437-
err = read_poll_timeout(wx_poll_fw_reply, reply, reply, 1000, 50000,
438-
true, wx, buffer, send_cmd);
437+
err = read_poll_timeout(wx_poll_fw_reply, reply, reply, 2000,
438+
timeout * 1000, true, wx, buffer, send_cmd);
439439
if (err) {
440440
wx_err(wx, "Polling from FW messages timeout, cmd: 0x%x, index: %d\n",
441441
send_cmd, wx->swfw_index);

0 commit comments

Comments
 (0)