Skip to content

Commit 45b9545

Browse files
committed
drm/i915/display: Remove FBC modulo 4 restriction for ADL-P+
WA:22010751166 does not apply past display version 12. Or, in other words, the FBC restriction where FBC is disabled for non-modulo 4 plane sizes (including plane size + yoffset) is fixed from display version 13 and onwards. Relax the restriction for the same. v4: Dropped redundant commit message v3: Update comments for clarity (Jonathan Cavitt) v2: Update the macro for display version check (Vinod) Suggested-by: Vidya Srinivas <vidya.srinivas@intel.com> Signed-off-by: Uma Shankar <uma.shankar@intel.com> Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com> Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com> Link: https://lore.kernel.org/r/20250904095338.300813-2-uma.shankar@intel.com
1 parent 30c3ffb commit 45b9545

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/gpu/drm/i915/display/intel_fbc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1550,14 +1550,14 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
15501550
* having a Y offset that isn't divisible by 4 causes FIFO underrun
15511551
* and screen flicker.
15521552
*/
1553-
if (DISPLAY_VER(display) >= 9 &&
1553+
if (IS_DISPLAY_VER(display, 9, 12) &&
15541554
plane_state->view.color_plane[0].y & 3) {
15551555
plane_state->no_fbc_reason = "plane start Y offset misaligned";
15561556
return 0;
15571557
}
15581558

15591559
/* Wa_22010751166: icl, ehl, tgl, dg1, rkl */
1560-
if (DISPLAY_VER(display) >= 11 &&
1560+
if (IS_DISPLAY_VER(display, 9, 12) &&
15611561
(plane_state->view.color_plane[0].y +
15621562
(drm_rect_height(&plane_state->uapi.src) >> 16)) & 3) {
15631563
plane_state->no_fbc_reason = "plane end Y offset misaligned";

0 commit comments

Comments
 (0)