drm/amd/pm: Remove unnecessary variable

Asad Kamal · alexdeucher · commit 461f43b9b65e · 2025-07-16T16:14:51.000-04:00
Remove unnecessary variable ret from smu_v13_0_12_get_smu_metrics_data Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202507150618.WOfvWsQF-lkp@intel.com Signed-off-by: Asad Kamal <asad.kamal@amd.com> Reviewed-by: Lijo Lazar <lijo.lazar@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_12_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_12_ppt.c
@@ -301,7 +301,6 @@ int smu_v13_0_12_get_smu_metrics_data(struct smu_context *smu,
 	struct smu_table_context *smu_table = &smu->smu_table;
 	MetricsTable_t *metrics = (MetricsTable_t *)smu_table->metrics_table;
 	struct amdgpu_device *adev = smu->adev;
-	int ret = 0;
 	int xcc_id;
 
 	/* For clocks with multiple instances, only report the first one */
@@ -357,7 +356,7 @@ int smu_v13_0_12_get_smu_metrics_data(struct smu_context *smu,
 		break;
 	}
 
-	return ret;
+	return 0;
 }
 
 ssize_t smu_v13_0_12_get_xcp_metrics(struct smu_context *smu, struct amdgpu_xcp *xcp, void *table, void *smu_metrics)

Original file line number	Diff line number	Diff line change
`@@ -301,7 +301,6 @@ int smu_v13_0_12_get_smu_metrics_data(struct smu_context *smu,`
`301`	`301`	`struct smu_table_context *smu_table = &smu->smu_table;`
`302`	`302`	`MetricsTable_t metrics = (MetricsTable_t )smu_table->metrics_table;`
`303`	`303`	`struct amdgpu_device *adev = smu->adev;`
`304`		`- int ret = 0;`
`305`	`304`	`int xcc_id;`
`306`	`305`
`307`	`306`	`/* For clocks with multiple instances, only report the first one */`
`@@ -357,7 +356,7 @@ int smu_v13_0_12_get_smu_metrics_data(struct smu_context *smu,`
`357`	`356`	`break;`
`358`	`357`	`}`
`359`	`358`
`360`		`- return ret;`
	`359`	`+ return 0;`
`361`	`360`	`}`
`362`	`361`
`363`	`362`	`ssize_t smu_v13_0_12_get_xcp_metrics(struct smu_context smu, struct amdgpu_xcp xcp, void table, void smu_metrics)`