Skip to content

Commit 46eba93

Browse files
Christoph Hellwigcmaiolino
authored andcommitted
xfs: simplify xfsaild_resubmit_item
Since commit acc8f86 ("xfs: attach dquot buffer to dquot log item buffer") all buf items that use bp->b_li_list are explicitly checked for in the branch to just clears XFS_LI_FAILED. Remove the dead arm that calls xfs_clear_li_failed. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Darrick J. Wong <djwong@kernel.org> Acked-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Carlos Maiolino <cem@kernel.org>
1 parent 819f29c commit 46eba93

1 file changed

Lines changed: 2 additions & 7 deletions

File tree

fs/xfs/xfs_trans_ail.c

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -359,13 +359,8 @@ xfsaild_resubmit_item(
359359
}
360360

361361
/* protected by ail_lock */
362-
list_for_each_entry(lip, &bp->b_li_list, li_bio_list) {
363-
if (bp->b_flags & (_XBF_INODES | _XBF_DQUOTS))
364-
clear_bit(XFS_LI_FAILED, &lip->li_flags);
365-
else
366-
xfs_clear_li_failed(lip);
367-
}
368-
362+
list_for_each_entry(lip, &bp->b_li_list, li_bio_list)
363+
clear_bit(XFS_LI_FAILED, &lip->li_flags);
369364
xfs_buf_unlock(bp);
370365
return XFS_ITEM_SUCCESS;
371366
}

0 commit comments

Comments
 (0)