Skip to content

Commit 474014c

Browse files
tititiou36Bartosz Golaszewski
authored andcommitted
gpio: pisosr: Use devm_mutex_init()
Use devm_mutex_init() instead of hand-writing it. This saves some LoC, improves readability and saves some space in the generated .o file. Before: ====== text data bss dec hex filename 8431 1808 192 10431 28bf drivers/gpio/gpio-pisosr.o After: ===== text data bss dec hex filename 8112 1736 192 10040 2738 drivers/gpio/gpio-pisosr.o Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Acked-by: Andrew Davis <afd@ti.com> Link: https://lore.kernel.org/r/01910ebdaba7d8d0cdc4ac60eb70da8e29cb85f1.1757251512.git.christophe.jaillet@wanadoo.fr Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
1 parent 03c146c commit 474014c

1 file changed

Lines changed: 1 addition & 7 deletions

File tree

drivers/gpio/gpio-pisosr.c

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -108,11 +108,6 @@ static const struct gpio_chip template_chip = {
108108
.can_sleep = true,
109109
};
110110

111-
static void pisosr_mutex_destroy(void *lock)
112-
{
113-
mutex_destroy(lock);
114-
}
115-
116111
static int pisosr_gpio_probe(struct spi_device *spi)
117112
{
118113
struct device *dev = &spi->dev;
@@ -139,8 +134,7 @@ static int pisosr_gpio_probe(struct spi_device *spi)
139134
return dev_err_probe(dev, PTR_ERR(gpio->load_gpio),
140135
"Unable to allocate load GPIO\n");
141136

142-
mutex_init(&gpio->lock);
143-
ret = devm_add_action_or_reset(dev, pisosr_mutex_destroy, &gpio->lock);
137+
ret = devm_mutex_init(dev, &gpio->lock);
144138
if (ret)
145139
return ret;
146140

0 commit comments

Comments
 (0)