Skip to content

Commit 4996b4c

Browse files
Timur Kristófalexdeucher
authored andcommitted
drm/amdgpu/gmc6: Delegate VM faults to soft IRQ handler ring
On old GPUs, it may be an issue that handling the interrupts from VM faults is too slow and the interrupt handler (IH) ring may overflow, which can cause an eventual hang. Delegate the processing of all VM faults to the soft IRQ handler ring. As a result, we spend much less time in the IRQ handler that interacts with the HW IH ring, which significantly reduces the chance of hangs/reboots. Signed-off-by: Timur Kristóf <timur.kristof@gmail.com> Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Christian König <christian.koenig@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 61673ef commit 4996b4c

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1070,6 +1070,12 @@ static int gmc_v6_0_process_interrupt(struct amdgpu_device *adev,
10701070
{
10711071
u32 addr, status;
10721072

1073+
/* Delegate to the soft IRQ handler ring */
1074+
if (adev->irq.ih_soft.enabled && entry->ih != &adev->irq.ih_soft) {
1075+
amdgpu_irq_delegate(adev, entry, 4);
1076+
return 1;
1077+
}
1078+
10731079
addr = RREG32(mmVM_CONTEXT1_PROTECTION_FAULT_ADDR);
10741080
status = RREG32(mmVM_CONTEXT1_PROTECTION_FAULT_STATUS);
10751081
WREG32_P(mmVM_CONTEXT1_CNTL2, 1, ~1);

0 commit comments

Comments
 (0)