Skip to content

Commit 49e50aa

Browse files
andy-shevlag-linaro
authored andcommitted
leds: core: Refactor led_update_brightness() to use standard pattern
The standard conditional pattern is to check for errors first and bail out if any. Refactor led_update_brightness() accordingly. While at it, drop unneeded assignment and return 0 unconditionally on success. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Denis Osterland-Heim <denis.osterland@diehl.com> Reviewed-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20231016153051.1409074-1-andriy.shevchenko@linux.intel.com Signed-off-by: Lee Jones <lee@kernel.org>
1 parent 78cbcfd commit 49e50aa

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

drivers/leds/led-core.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -364,17 +364,17 @@ EXPORT_SYMBOL_GPL(led_set_brightness_sync);
364364

365365
int led_update_brightness(struct led_classdev *led_cdev)
366366
{
367-
int ret = 0;
367+
int ret;
368368

369369
if (led_cdev->brightness_get) {
370370
ret = led_cdev->brightness_get(led_cdev);
371-
if (ret >= 0) {
372-
led_cdev->brightness = ret;
373-
return 0;
374-
}
371+
if (ret < 0)
372+
return ret;
373+
374+
led_cdev->brightness = ret;
375375
}
376376

377-
return ret;
377+
return 0;
378378
}
379379
EXPORT_SYMBOL_GPL(led_update_brightness);
380380

0 commit comments

Comments
 (0)