Skip to content

Commit 4be4ac3

Browse files
bardliaovinodkoul
authored andcommitted
soundwire: cadence_master: make frame index trace more readable
The existing code uses i as the frame index which is 0 based. And "bad frame %d/%d", i, num_frames where num_frames is 1 based. Change the frame index to i + 1 to align with num_frames and more readable. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Link: https://patch.msgid.link/20251014031450.3781789-2-yung-chuan.liao@linux.intel.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent b2bfe0f commit 4be4ac3

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

drivers/soundwire/cadence_master.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2495,14 +2495,14 @@ int sdw_cdns_check_write_response(struct device *dev, u8 *dma_buffer,
24952495
ret = check_frame_start(header, counter);
24962496
if (ret < 0) {
24972497
dev_err(dev, "%s: bad frame %d/%d start header %x\n",
2498-
__func__, i, num_frames, header);
2498+
__func__, i + 1, num_frames, header);
24992499
return ret;
25002500
}
25012501

25022502
ret = check_frame_end(footer);
25032503
if (ret < 0) {
25042504
dev_err(dev, "%s: bad frame %d/%d end footer %x\n",
2505-
__func__, i, num_frames, footer);
2505+
__func__, i + 1, num_frames, footer);
25062506
return ret;
25072507
}
25082508

@@ -2573,7 +2573,7 @@ int sdw_cdns_check_read_response(struct device *dev, u8 *dma_buffer, int dma_buf
25732573
ret = check_frame_start(header, counter);
25742574
if (ret < 0) {
25752575
dev_err(dev, "%s: bad frame %d/%d start header %x\n",
2576-
__func__, i, num_frames, header);
2576+
__func__, i + 1, num_frames, header);
25772577
return ret;
25782578
}
25792579

@@ -2588,7 +2588,7 @@ int sdw_cdns_check_read_response(struct device *dev, u8 *dma_buffer, int dma_buf
25882588

25892589
if (crc != expected_crc) {
25902590
dev_err(dev, "%s: bad frame %d/%d crc %#x expected %#x\n",
2591-
__func__, i, num_frames, crc, expected_crc);
2591+
__func__, i + 1, num_frames, crc, expected_crc);
25922592
return -EIO;
25932593
}
25942594

@@ -2599,7 +2599,7 @@ int sdw_cdns_check_read_response(struct device *dev, u8 *dma_buffer, int dma_buf
25992599
ret = check_frame_end(footer);
26002600
if (ret < 0) {
26012601
dev_err(dev, "%s: bad frame %d/%d end footer %x\n",
2602-
__func__, i, num_frames, footer);
2602+
__func__, i + 1, num_frames, footer);
26032603
return ret;
26042604
}
26052605

0 commit comments

Comments
 (0)