Skip to content

Commit 4c6a567

Browse files
morbidrsadubeyko
authored andcommitted
hfsplus: don't set REQ_SYNC for hfsplus_submit_bio()
hfsplus_submit_bio() called by hfsplus_sync_fs() uses bdev_virt_rw() which in turn uses submit_bio_wait() to submit the BIO. But submit_bio_wait() already sets the REQ_SYNC flag on the BIO so there is no need for setting the flag in hfsplus_sync_fs() when calling hfsplus_submit_bio(). Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Reviewed-by: Yangtao Li <frank.li@vivo.com> Reviewed-by: Viacheslav Dubeyko <slava@dubeyko.com> Signed-off-by: Viacheslav Dubeyko <slava@dubeyko.com> Link: https://lore.kernel.org/r/20250710063553.4805-1-johannes.thumshirn@wdc.com Link: https://lore.kernel.org/r/20250710063553.4805-1-johannes.thumshirn@wdc.com Signed-off-by: Viacheslav Dubeyko <slava@dubeyko.com>
1 parent fcb9695 commit 4c6a567

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

fs/hfsplus/super.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -222,17 +222,15 @@ static int hfsplus_sync_fs(struct super_block *sb, int wait)
222222

223223
error2 = hfsplus_submit_bio(sb,
224224
sbi->part_start + HFSPLUS_VOLHEAD_SECTOR,
225-
sbi->s_vhdr_buf, NULL, REQ_OP_WRITE |
226-
REQ_SYNC);
225+
sbi->s_vhdr_buf, NULL, REQ_OP_WRITE);
227226
if (!error)
228227
error = error2;
229228
if (!write_backup)
230229
goto out;
231230

232231
error2 = hfsplus_submit_bio(sb,
233232
sbi->part_start + sbi->sect_count - 2,
234-
sbi->s_backup_vhdr_buf, NULL, REQ_OP_WRITE |
235-
REQ_SYNC);
233+
sbi->s_backup_vhdr_buf, NULL, REQ_OP_WRITE);
236234
if (!error)
237235
error2 = error;
238236
out:

0 commit comments

Comments
 (0)