Skip to content

Commit 4f423c4

Browse files
lumagandersson
authored andcommitted
Revert "arm64: dts: qcom: msm8996: Hook up MPM"
Commit 09896da ("arm64: dts: qcom: msm8996: Hook up MPM") has hooked up the MPM irq chip on the MSM8996 platform. However this causes my Dragonboard 820c crash during bootup (usually when probing IOMMUs). Revert the offending commit for now. Quick debug shows that making tlmm's wakeup-parent point to the MPM is enough to trigger the crash. Fixes: 09896da ("arm64: dts: qcom: msm8996: Hook up MPM") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Link: https://lore.kernel.org/r/20240221-msm8996-revert-mpm-v1-1-cdca9e30c9b4@linaro.org Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent 7a1c6a8 commit 4f423c4

1 file changed

Lines changed: 6 additions & 33 deletions

File tree

arch/arm64/boot/dts/qcom/msm8996.dtsi

Lines changed: 6 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -457,25 +457,6 @@
457457
};
458458
};
459459

460-
mpm: interrupt-controller {
461-
compatible = "qcom,mpm";
462-
qcom,rpm-msg-ram = <&apss_mpm>;
463-
interrupts = <GIC_SPI 171 IRQ_TYPE_EDGE_RISING>;
464-
mboxes = <&apcs_glb 1>;
465-
interrupt-controller;
466-
#interrupt-cells = <2>;
467-
#power-domain-cells = <0>;
468-
interrupt-parent = <&intc>;
469-
qcom,mpm-pin-count = <96>;
470-
qcom,mpm-pin-map = <2 184>, /* TSENS1 upper_lower_int */
471-
<52 243>, /* DWC3_PRI ss_phy_irq */
472-
<79 347>, /* DWC3_PRI hs_phy_irq */
473-
<80 352>, /* DWC3_SEC hs_phy_irq */
474-
<81 347>, /* QUSB2_PHY_PRI DP+DM */
475-
<82 352>, /* QUSB2_PHY_SEC DP+DM */
476-
<87 326>; /* SPMI */
477-
};
478-
479460
psci {
480461
compatible = "arm,psci-1.0";
481462
method = "smc";
@@ -765,15 +746,8 @@
765746
};
766747

767748
rpm_msg_ram: sram@68000 {
768-
compatible = "qcom,rpm-msg-ram", "mmio-sram";
749+
compatible = "qcom,rpm-msg-ram";
769750
reg = <0x00068000 0x6000>;
770-
#address-cells = <1>;
771-
#size-cells = <1>;
772-
ranges = <0 0x00068000 0x7000>;
773-
774-
apss_mpm: sram@1b8 {
775-
reg = <0x1b8 0x48>;
776-
};
777751
};
778752

779753
qfprom@74000 {
@@ -856,8 +830,8 @@
856830
reg = <0x004ad000 0x1000>, /* TM */
857831
<0x004ac000 0x1000>; /* SROT */
858832
#qcom,sensors = <8>;
859-
interrupts-extended = <&mpm 2 IRQ_TYPE_LEVEL_HIGH>,
860-
<&intc GIC_SPI 430 IRQ_TYPE_LEVEL_HIGH>;
833+
interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>,
834+
<GIC_SPI 430 IRQ_TYPE_LEVEL_HIGH>;
861835
interrupt-names = "uplow", "critical";
862836
#thermal-sensor-cells = <1>;
863837
};
@@ -1363,7 +1337,6 @@
13631337
interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
13641338
gpio-controller;
13651339
gpio-ranges = <&tlmm 0 0 150>;
1366-
wakeup-parent = <&mpm>;
13671340
#gpio-cells = <2>;
13681341
interrupt-controller;
13691342
#interrupt-cells = <2>;
@@ -1891,7 +1864,7 @@
18911864
<0x0400a000 0x002100>;
18921865
reg-names = "core", "chnls", "obsrvr", "intr", "cnfg";
18931866
interrupt-names = "periph_irq";
1894-
interrupts-extended = <&mpm 87 IRQ_TYPE_LEVEL_HIGH>;
1867+
interrupts = <GIC_SPI 326 IRQ_TYPE_LEVEL_HIGH>;
18951868
qcom,ee = <0>;
18961869
qcom,channel = <0>;
18971870
#address-cells = <2>;
@@ -3052,8 +3025,8 @@
30523025
#size-cells = <1>;
30533026
ranges;
30543027

3055-
interrupts-extended = <&mpm 79 IRQ_TYPE_LEVEL_HIGH>,
3056-
<&mpm 52 IRQ_TYPE_LEVEL_HIGH>;
3028+
interrupts = <GIC_SPI 347 IRQ_TYPE_LEVEL_HIGH>,
3029+
<GIC_SPI 243 IRQ_TYPE_LEVEL_HIGH>;
30573030
interrupt-names = "hs_phy_irq", "ss_phy_irq";
30583031

30593032
clocks = <&gcc GCC_SYS_NOC_USB3_AXI_CLK>,

0 commit comments

Comments
 (0)