NFSv4: Clear the NFS_CAP_XATTR flag if not supported by the server

Trond Myklebust · Trond Myklebust · commit 4fb2b677fc1f · 2025-08-29T12:56:43.000-04:00
nfs_server_set_fsinfo() shouldn't assume that NFS_CAP_XATTR is unset on entry to the function. Fixes: b78ef84 ("NFSv4.2: query the server for extended attribute support") Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
diff --git a/fs/nfs/client.c b/fs/nfs/client.c
@@ -888,6 +888,8 @@ static void nfs_server_set_fsinfo(struct nfs_server *server,
 
 	if (fsinfo->xattr_support)
 		server->caps |= NFS_CAP_XATTR;
+	else
+		server->caps &= ~NFS_CAP_XATTR;
 #endif
 }
 

Original file line number	Diff line number	Diff line change
`@@ -888,6 +888,8 @@ static void nfs_server_set_fsinfo(struct nfs_server *server,`
`888`	`888`
`889`	`889`	`if (fsinfo->xattr_support)`
`890`	`890`	`server->caps \|= NFS_CAP_XATTR;`
	`891`	`+ else`
	`892`	`+ server->caps &= ~NFS_CAP_XATTR;`
`891`	`893`	`#endif`
`892`	`894`	`}`
`893`	`895`