Skip to content

Commit 508e754

Browse files
GustavoARSilvamartinkpetersen
authored andcommitted
scsi: pm80xx: Avoid -Wflex-array-member-not-at-end warnings
Comment out unused field 'residual_count' in a couple of structures, and with this, fix the following -Wflex-array-member-not-at-end warnings: drivers/scsi/pm8001/pm8001_hwi.h:342:33: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] drivers/scsi/pm8001/pm80xx_hwi.h:561:32: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] Reviewed-by: Jack Wang <jinpu.wang@ionos.com> Reviewed-by: John Garry <john.g.garry@oracle.com> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 3126b5f commit 508e754

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

drivers/scsi/pm8001/pm8001_hwi.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -339,8 +339,10 @@ struct ssp_completion_resp {
339339
__le32 status;
340340
__le32 param;
341341
__le32 ssptag_rescv_rescpad;
342+
343+
/* Must be last --ends in a flexible-array member. */
342344
struct ssp_response_iu ssp_resp_iu;
343-
__le32 residual_count;
345+
/* __le32 residual_count; */
344346
} __attribute__((packed, aligned(4)));
345347

346348

drivers/scsi/pm8001/pm80xx_hwi.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -558,8 +558,10 @@ struct ssp_completion_resp {
558558
__le32 status;
559559
__le32 param;
560560
__le32 ssptag_rescv_rescpad;
561+
562+
/* Must be last --ends in a flexible-array member. */
561563
struct ssp_response_iu ssp_resp_iu;
562-
__le32 residual_count;
564+
/* __le32 residual_count; */
563565
} __attribute__((packed, aligned(4)));
564566

565567
#define SSP_RESCV_BIT 0x00010000

0 commit comments

Comments
 (0)